Finetuning YDB adapter #1447
Open
Finetuning YDB adapter #1447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Split into 2 PRs:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For many analytical queries in YDB, it is preferable to pass parameters directly within the query text. Otherwise, certain queries may not function correctly or may perform less efficiently than possible. In previous versions of the YDB libraries, parameter substitution was handled by the DBAPI. However, I believe a more robust approach is to use literal_binds=True. In this PR, I introduce the ability to override this behavior for specific adapters, and I enable it for YDB.
Additionally, I have implemented custom query timeout settings. This ensures that if a query times out on the DataLens side, it will no longer continue to execute on the YDB side.